From: mdroth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com,
qemu-stable@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart
Date: Wed, 20 Mar 2013 16:15:59 -0500 [thread overview]
Message-ID: <20130320211559.GF1580@vm> (raw)
In-Reply-To: <20130320155618.336f1171@doriath>
On Wed, Mar 20, 2013 at 03:56:18PM -0400, Luiz Capitulino wrote:
> On Wed, 20 Mar 2013 14:39:55 -0500
> mdroth <mdroth@linux.vnet.ibm.com> wrote:
>
> > So I wonder if, rather than pursuing option 3, we just introduce an
> > interface that does what we really want and returns handles as UUIDs,
> > then mark the existing interfaces as deprecated (and then remove them
> > within the next 300 years so our assert never gets hit :)
>
> This seems reasonable to me. It should be an assert() if it should never
> happen. If we feel like doing option 3, we introduce a new interface
> that handles UUIDs instead.
>
Ok, I think it's a plan then. I have a partial implementation for
guest-file-* commands on windows, and a posix/w32 guest-exec-async
implementation that re-uses them, so maybe those should be introduced
around the new interfaces to avoid churn. Need to generate uuid handles
for guest-exec handles anyway.
next prev parent reply other threads:[~2013-03-20 21:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 17:40 [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart Michael Roth
2013-03-05 22:57 ` mdroth
2013-03-20 14:54 ` Luiz Capitulino
2013-03-20 16:03 ` mdroth
2013-03-20 16:58 ` Luiz Capitulino
2013-03-20 17:26 ` mdroth
2013-03-20 17:40 ` Luiz Capitulino
2013-03-20 18:14 ` mdroth
2013-03-20 18:38 ` Luiz Capitulino
2013-03-20 19:39 ` mdroth
2013-03-20 19:56 ` Luiz Capitulino
2013-03-20 21:15 ` mdroth [this message]
2013-03-21 7:03 ` Markus Armbruster
2013-03-21 16:13 ` mdroth
2013-03-21 18:24 ` Luiz Capitulino
2013-03-21 18:35 ` mdroth
2013-03-21 19:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320211559.GF1580@vm \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).