From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations
Date: Thu, 21 Mar 2013 11:29:59 +0100 [thread overview]
Message-ID: <20130321102959.GB2726@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <514A2B4A.1050804@redhat.com>
Am 20.03.2013 um 22:34 hat Eric Blake geschrieben:
> On 03/20/2013 12:39 PM, Kevin Wolf wrote:
> > A file name may only specified if no host or socket path is specified.
> > The latter two may not appear at the same time either.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > block/nbd.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> I'm assuming that the rest of the series is unchanged, on the commits
> where you carried forward my v1 review.
I think I've added a spelling fix or two for things you pointed out, but
other than that they are unchanged, yes.
Thanks for your review, Eric!
Kevin
prev parent reply other threads:[~2013-03-21 11:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 18:39 [Qemu-devel] [PATCH v2 00/12] block: Driver-specific options for protocols Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 01/12] block: Add options QDict to bdrv_file_open() prototypes Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 02/12] block: Pass bdrv_file_open() options to block drivers Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 03/12] qemu-socket: Make socket_optslist public Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 04/12] nbd: Keep hostname and port separate Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 05/12] nbd: Remove unused functions Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 06/12] nbd: Accept -drive options for the network connection Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 07/12] block: Introduce .bdrv_parse_filename callback Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 08/12] block: Rename variable to avoid shadowing Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 09/12] block: Make find_image_format safe with NULL filename Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 10/12] block: Allow omitting the file name when using driver-specific options Kevin Wolf
2013-03-20 21:31 ` Eric Blake
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 11/12] nbd: Use default port if only host is specified Kevin Wolf
2013-03-20 18:39 ` [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations Kevin Wolf
2013-03-20 21:34 ` Eric Blake
2013-03-21 10:29 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321102959.GB2726@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).