From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIeiS-0007Bw-S8 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIeiO-0000UA-5B for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:35:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIeiN-0000Tz-Tk for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:35:28 -0400 Date: Thu, 21 Mar 2013 14:36:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20130321123607.GD32484@redhat.com> References: <1363821803-3380-1-git-send-email-lersek@redhat.com> <1363821803-3380-5-git-send-email-lersek@redhat.com> <514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com> <514AE3F4.9050002@redhat.com> <514AF446.4020004@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <514AF446.4020004@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, Laszlo Ersek , kraxel@redhat.com, qemu-devel@nongnu.org On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: > Il 21/03/2013 11:41, Laszlo Ersek ha scritto: > > On 03/21/13 01:31, Laszlo Ersek wrote: > >> On 03/21/13 00:45, Eric Blake wrote: > >>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > > > >>>> +# > >>>> +# @oem_id: #optional OEM identifier (6 bytes) > >>> > >>> s/oem_id/oem-id/ > >>> > >>> In general, new QMP interfaces should use '-', not '_'. > >> > >> Indeed! I think this warrants a respin. > > > > Actually it doesn't, apologies -- I got confused for a minute. Again, > > since I aim to match the existing option format, I must keep the same > > spelling. > > We should make a list of places where we have mixed conventions, accept > both, and mass-convert to dash... > > Paolo Anthony used to nack all mass conversions since they mess up the git history. Since the movement of headers went in, I gather this position has been relaxed... -- MST