From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UIwKM-0000hl-L8
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:23:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UIwKL-0000ci-Ij
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:23:50 -0400
Received: from [222.73.24.84] (port=30140 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UIwKL-0000cD-6K
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:23:49 -0400
Date: Fri, 22 Mar 2013 15:23:47 +0800
From: Hu Tao <hutao@cn.fujitsu.com>
Message-ID: <20130322072347.GE24459@localhost.localdomain>
References: <cover.1363847789.git.hutao@cn.fujitsu.com>
	<1363856914-23399-2-git-send-email-hutao@cn.fujitsu.com>
	<20130321225458.GA1279@morn.localdomain>
MIME-Version: 1.0
In-Reply-To: <20130321225458.GA1279@morn.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v15 2/2] patch dsdt to use
 passed-in pvpanic ioport
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Gleb Natapov <gleb@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, Juan Quintela <quintela@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Andrew Jones <drjones@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Mar 21, 2013 at 06:54:59PM -0400, Kevin O'Connor wrote:
> On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote:
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> 
> I don't think it is a good idea to dynamically modify the DSDT.  We've
> been using the SSDT for that.
> 
> In any case, I think this would be a good candidate for merging after
> the ACPI stuff is moved into QEMU.

Agreed. What do you think about patch 1? (of course with Paolo's
suggestion applied)

> 
> -Kevin