From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UIwiI-0002Nm-So
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:48:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UIwiH-0000ps-P3
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:48:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25181)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1UIwiH-0000pd-Hp
	for qemu-devel@nongnu.org; Fri, 22 Mar 2013 03:48:33 -0400
Date: Fri, 22 Mar 2013 09:48:18 +0200
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20130322074818.GM9382@redhat.com>
References: <cover.1363847789.git.hutao@cn.fujitsu.com>
	<1363856914-23399-2-git-send-email-hutao@cn.fujitsu.com>
	<514ACEDA.8080506@redhat.com>
	<20130321091711.GB21556@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130321091711.GB21556@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in
	pvpanic ioport
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Orit Wasserman <owasserm@redhat.com>, Juan Quintela <quintela@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Andrew Jones <drjones@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Sasha Levin <levinsasha928@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Anthony Liguori <aliguori@us.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Thu, Mar 21, 2013 at 05:17:11PM +0800, Hu Tao wrote:
> On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote:
> > Il 21/03/2013 10:08, Hu Tao ha scritto:
> > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > > ---
> > >  src/acpi-dsdt-isa.dsl | 14 ++++++++++++--
> > >  src/acpi.c            |  9 +++++++++
> > >  2 files changed, 21 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl
> > > index 87a31b9..43fe719 100644
> > > --- a/src/acpi-dsdt-isa.dsl
> > > +++ b/src/acpi-dsdt-isa.dsl
> > > @@ -102,7 +102,9 @@ Scope(\_SB.PCI0.ISA) {
> > >  
> > >      Device(PEVT) {
> > >          Name(_HID, "QEMU0001")
> > > -        OperationRegion(PEOR, SystemIO, 0x0505, 0x01)
> > > +        ACPI_EXTRACT_NAME_WORD_CONST dsdt_isa_pest
> > > +        Name(PEST, 0x505)
> > > +        OperationRegion(PEOR, SystemIO, PEST, 0x01)
> > >          Field(PEOR, ByteAcc, NoLock, Preserve) {
> > >              PEPT,   8,
> > >          }
> > > @@ -126,7 +128,15 @@ Scope(\_SB.PCI0.ISA) {
> > >          }
> > >  
> > >          Name(_CRS, ResourceTemplate() {
> > > -            IO(Decode16, 0x0505, 0x0505, 0x01, 0x01)
> > > +            IO(Decode16, 0x0505, 0x0505, 0x01, 0x01, IO)
> > >          })
> > > +
> > > +        CreateWordField(_CRS, IO._MIN, IOMN)
> > > +        CreateWordField(_CRS, IO._MAX, IOMX)
> > > +
> > > +        Method(_INI, 0, NotSerialized) {
> > > +            Store(PEST, IOMN)
> > > +            Store(PEST, IOMX)
> > > +        }
> > >      }
> > >  }
> > > diff --git a/src/acpi.c b/src/acpi.c
> > > index 119d1c1..42fa06e 100644
> > > --- a/src/acpi.c
> > > +++ b/src/acpi.c
> > > @@ -286,11 +286,20 @@ static const struct pci_device_id fadt_init_tbl[] = {
> > >      PCI_DEVICE_END
> > >  };
> > >  
> > > +static void patch_dsdt(void *dsdt)
> > > +{
> > > +    u8 *dsdt_ptr = dsdt;
> > > +    int pvpanic_port = romfile_loadint("etc/pvpanic-port", 0x505);
> > 
> > The default must be 0.
> > 
> > Also, here:
> > 
> > 
> > +
> > +        Method(_STA, 0, NotSerialized) {
> > +            Store(PEPT, Local0)
> > +            If (LEqual(Local0, Zero)) {
> > +                Return (0x00)
> > +            } Else {
> > +                Return (0x0F)
> > +            }
> > +        }
> > +
> > 
> > You must change it to look at PEST instead of PEPT (i.e. do not probe,
> > just see if you have a meaningful address).
> > 
> > Just squash the patches, it's simpler that way probably.
> 
> I forgot to add RFC to the title. This patch doesn't work for q35 with
> custom ioport.
> 
Why doesn't it work with q35?

--
			Gleb.