qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] block/curl: Add support for Secure Shell (ssh/sftp) block device
Date: Fri, 22 Mar 2013 14:41:24 +0100	[thread overview]
Message-ID: <20130322134124.GA32299@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20130322130455.GI1504@rhmail.home.annexia.org>

On Fri, Mar 22, 2013 at 01:04:55PM +0000, Richard W.M. Jones wrote:
> 
> I got it working with Curl, patch attached.
> 
> However there are multiple issues (these are mainly notes for myself):
> 
> (1) libcurl cannot read the size of the file.  I had to hard-code
> this.  This is probably just a shortcoming of libcurl (libssh2/sftp
> itself can read the size of files).  Will try to work on a patch for
> upstream.
> 
> (2) Fedora's curl (which is heavily patched) is broken in some way and
> deadlocks itself.  Upstream curl from git works better.  I haven't yet
> identified which patch/commit is responsible.
> 
> (3) ssh-agent authentication doesn't work.  It appears that either
> ssh-agent itself doesn't like multiple connections from a single
> process (qemu), or libcurl/libssh2 is having a problem with making
> multiple connections out to ssh-agent.  If I disable ssh-agent auth,
> it works.  Still investigating this.
> 
> (4) You must specify a user@ in the URL, else libcurl tries to
> authenticate as user "".  I will see if I can send a fix for this
> upstream.
> 
> (5) Although it gets much of the way through a boot of a guest, it
> eventually segfaults.  Still investigating this.
> 
> (6) There are several more issues marked by XXX's in the code.

Thank you for improving libcurl!  You're making it better for everybody.

A lot of people go back to NIH when they hit limitations in existing
software.

Stefan

  reply	other threads:[~2013-03-22 13:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 13:38 [Qemu-devel] [PATCH] Add support for Secure Shell (ssh) block device Richard W.M. Jones
2013-03-21 13:38 ` [Qemu-devel] [PATCH] block: " Richard W.M. Jones
2013-03-21 15:26   ` Stefan Hajnoczi
2013-03-21 15:39     ` Richard W.M. Jones
2013-03-21 19:29       ` Stefan Hajnoczi
2013-03-21 19:35   ` Stefan Hajnoczi
2013-03-21 20:31     ` Richard W.M. Jones
2013-03-22 13:04     ` [Qemu-devel] [PATCH] block/curl: Add support for Secure Shell (ssh/sftp) " Richard W.M. Jones
2013-03-22 13:41       ` Stefan Hajnoczi [this message]
2013-03-25 12:32       ` Richard W.M. Jones
2013-03-25 13:12         ` Stefan Hajnoczi
2013-03-25 14:36   ` [Qemu-devel] [PATCH] block: Add support for Secure Shell (ssh) " Kevin Wolf
2013-03-25 15:11     ` Richard W.M. Jones
2013-03-26  9:37       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322134124.GA32299@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).