From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ2Dt-0004Bc-OG for qemu-devel@nongnu.org; Fri, 22 Mar 2013 09:41:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJ2Dp-0001Kb-1S for qemu-devel@nongnu.org; Fri, 22 Mar 2013 09:41:33 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:50788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ2Do-0001KP-Rh for qemu-devel@nongnu.org; Fri, 22 Mar 2013 09:41:28 -0400 Received: by mail-wg0-f45.google.com with SMTP id dq12so3261389wgb.24 for ; Fri, 22 Mar 2013 06:41:28 -0700 (PDT) Date: Fri, 22 Mar 2013 14:41:24 +0100 From: Stefan Hajnoczi Message-ID: <20130322134124.GA32299@stefanha-thinkpad.redhat.com> References: <1363873138-30568-1-git-send-email-rjones@redhat.com> <1363873138-30568-2-git-send-email-rjones@redhat.com> <20130322130455.GI1504@rhmail.home.annexia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130322130455.GI1504@rhmail.home.annexia.org> Subject: Re: [Qemu-devel] [PATCH] block/curl: Add support for Secure Shell (ssh/sftp) block device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel On Fri, Mar 22, 2013 at 01:04:55PM +0000, Richard W.M. Jones wrote: > > I got it working with Curl, patch attached. > > However there are multiple issues (these are mainly notes for myself): > > (1) libcurl cannot read the size of the file. I had to hard-code > this. This is probably just a shortcoming of libcurl (libssh2/sftp > itself can read the size of files). Will try to work on a patch for > upstream. > > (2) Fedora's curl (which is heavily patched) is broken in some way and > deadlocks itself. Upstream curl from git works better. I haven't yet > identified which patch/commit is responsible. > > (3) ssh-agent authentication doesn't work. It appears that either > ssh-agent itself doesn't like multiple connections from a single > process (qemu), or libcurl/libssh2 is having a problem with making > multiple connections out to ssh-agent. If I disable ssh-agent auth, > it works. Still investigating this. > > (4) You must specify a user@ in the URL, else libcurl tries to > authenticate as user "". I will see if I can send a fix for this > upstream. > > (5) Although it gets much of the way through a boot of a guest, it > eventually segfaults. Still investigating this. > > (6) There are several more issues marked by XXX's in the code. Thank you for improving libcurl! You're making it better for everybody. A lot of people go back to NIH when they hit limitations in existing software. Stefan