qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: "KONRAD Frédéric" <fred.konrad@greensocs.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] Abort in monitor_puts.
Date: Fri, 22 Mar 2013 16:50:39 -0400	[thread overview]
Message-ID: <20130322165039.32aae1fb@doriath> (raw)
In-Reply-To: <514C21C6.3070800@greensocs.com>

On Fri, 22 Mar 2013 10:17:58 +0100
KONRAD Frédéric <fred.konrad@greensocs.com> wrote:

> Hi,
> 
> Seems there is an issue with the current git (found by toddf on IRC).
> 
> To reproduce:
> 
> ./qemu-system-x86_64 --monitor stdio --nographic
> 
> and put "?" it should abort.
> 
> Here is the backtrace:
> 
> #0  0x00007f77cd347935 in raise () from /lib64/libc.so.6
> #1  0x00007f77cd3490e8 in abort () from /lib64/libc.so.6
> #2  0x00007f77cd3406a2 in __assert_fail_base () from /lib64/libc.so.6
> #3  0x00007f77cd340752 in __assert_fail () from /lib64/libc.so.6
> #4  0x00007f77d1c1f226 in monitor_puts (mon=<optimized out>,
>      str=<optimized out>) at 

Yes, it's easy to reproduce. Bisect says:

f628926bb423fa8a7e0b114511400ea9df38b76a is the first bad commit
commit f628926bb423fa8a7e0b114511400ea9df38b76a
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Tue Mar 19 10:57:56 2013 +0100

    fix monitor
    
    chardev flow control broke monitor, fix it by adding watch support.
    
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

My impression is that monitor_puts() in being called in parallel.

  reply	other threads:[~2013-03-22 20:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  9:17 [Qemu-devel] Abort in monitor_puts KONRAD Frédéric
2013-03-22 20:50 ` Luiz Capitulino [this message]
2013-03-22 21:39   ` Luiz Capitulino
2013-03-25  7:42     ` Gerd Hoffmann
2013-03-25 11:56       ` Luiz Capitulino
2013-03-25 20:11         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322165039.32aae1fb@doriath \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=fred.konrad@greensocs.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).