* [Qemu-devel] [PATCH] rbd: fix compile error
@ 2013-03-24 7:41 Liu Yuan
2013-03-24 8:06 ` Stefan Weil
2013-03-25 8:53 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Liu Yuan @ 2013-03-24 7:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi
From: Liu Yuan <tailai.ly@taobao.com>
Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes] didn't
update rbd.c accordingly.
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
---
block/rbd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 8cd10a7..1a8ea6d 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -441,7 +441,8 @@ static int qemu_rbd_aio_flush_cb(void *opaque)
return (s->qemu_aio_count > 0);
}
-static int qemu_rbd_open(BlockDriverState *bs, const char *filename, int flags)
+static int qemu_rbd_open(BlockDriverState *bs, const char *filename,
+ QDict *options, int flags)
{
BDRVRBDState *s = bs->opaque;
char pool[RBD_MAX_POOL_NAME_SIZE];
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] rbd: fix compile error
2013-03-24 7:41 [Qemu-devel] [PATCH] rbd: fix compile error Liu Yuan
@ 2013-03-24 8:06 ` Stefan Weil
2013-03-25 8:53 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2013-03-24 8:06 UTC (permalink / raw)
To: Liu Yuan; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
Am 24.03.2013 08:41, schrieb Liu Yuan:
> From: Liu Yuan <tailai.ly@taobao.com>
>
> Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes] didn't
> update rbd.c accordingly.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
> block/rbd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 8cd10a7..1a8ea6d 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -441,7 +441,8 @@ static int qemu_rbd_aio_flush_cb(void *opaque)
> return (s->qemu_aio_count > 0);
> }
>
> -static int qemu_rbd_open(BlockDriverState *bs, const char *filename, int flags)
> +static int qemu_rbd_open(BlockDriverState *bs, const char *filename,
> + QDict *options, int flags)
> {
> BDRVRBDState *s = bs->opaque;
> char pool[RBD_MAX_POOL_NAME_SIZE];
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] rbd: fix compile error
2013-03-24 7:41 [Qemu-devel] [PATCH] rbd: fix compile error Liu Yuan
2013-03-24 8:06 ` Stefan Weil
@ 2013-03-25 8:53 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-03-25 8:53 UTC (permalink / raw)
To: Liu Yuan; +Cc: Kevin Wolf, qemu-devel
On Sun, Mar 24, 2013 at 03:41:15PM +0800, Liu Yuan wrote:
> From: Liu Yuan <tailai.ly@taobao.com>
>
> Commit 787e4a85 [block: Add options QDict to bdrv_file_open() prototypes] didn't
> update rbd.c accordingly.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <tailai.ly@taobao.com>
> ---
> block/rbd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-25 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-24 7:41 [Qemu-devel] [PATCH] rbd: fix compile error Liu Yuan
2013-03-24 8:06 ` Stefan Weil
2013-03-25 8:53 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).