From: Luiz Capitulino <lcapitulino@redhat.com>
To: Michal Novotny <minovotn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP command cpu_max
Date: Mon, 25 Mar 2013 12:27:05 -0400 [thread overview]
Message-ID: <20130325122705.252ec622@redhat.com> (raw)
In-Reply-To: <51507A22.2050101@redhat.com>
On Mon, 25 Mar 2013 17:24:02 +0100
Michal Novotny <minovotn@redhat.com> wrote:
> >> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
> >> +{
> >> + int cpu_max;
> >> + Error *errp = NULL;
> >> +
> >> + cpu_max = qmp_query_cpu_max(&errp);
> >> + if (errp) {
> >> + monitor_printf(mon, "%s\n", error_get_pretty(errp));
> >> + error_free(errp);
> >> + return;
> >> + }
> > Sorry for not noticing this before, but you can pass NULL to
> > qmp_query_cpu_max(), as it never fails.
>
>
> Ok, I just went according to the docs and there was no mention about
> it's possible to pass NULL. I don't know what magic qemu does with that
> one so I rather don't pass NULL. However, respin necessary?
If you look in hmp.c you'll see examples of this. Please respin, otherwise
we'll be committing code that is never used.
next prev parent reply other threads:[~2013-03-25 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 15:58 [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP command cpu_max Michal Novotny
2013-03-25 16:13 ` Luiz Capitulino
2013-03-25 16:24 ` Michal Novotny
2013-03-25 16:27 ` Luiz Capitulino [this message]
2013-03-25 16:31 ` Michal Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325122705.252ec622@redhat.com \
--to=lcapitulino@redhat.com \
--cc=minovotn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).