From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UKAEr-0007wt-3k
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:27:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UKAEl-0006Yc-Ap
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:27:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UKAEl-0006YM-4H
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 12:27:07 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2PGR6PG021600
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Mar 2013 12:27:06 -0400
Date: Mon, 25 Mar 2013 12:27:05 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130325122705.252ec622@redhat.com>
In-Reply-To: <51507A22.2050101@redhat.com>
References: <5641e296349cc434c7c03e4f51567c4210f9e426.1364212676.git.minovotn@redhat.com>
	<20130325121327.0aef9200@redhat.com> <51507A22.2050101@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] New QMP command query-cpu-max and HMP
 command cpu_max
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 25 Mar 2013 17:24:02 +0100
Michal Novotny <minovotn@redhat.com> wrote:

> >> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
> >> +{
> >> +    int cpu_max;
> >> +    Error *errp = NULL;
> >> +
> >> +    cpu_max = qmp_query_cpu_max(&errp);
> >> +    if (errp) {
> >> +        monitor_printf(mon, "%s\n", error_get_pretty(errp));
> >> +        error_free(errp);
> >> +        return;
> >> +    }
> > Sorry for not noticing this before, but you can pass NULL to
> > qmp_query_cpu_max(), as it never fails.
> 
> 
> Ok, I just went according to the docs and there was no mention about
> it's possible to pass NULL. I don't know what magic qemu does with that
> one so I rather don't pass NULL. However, respin necessary?

If you look in hmp.c you'll see examples of this. Please respin, otherwise
we'll be committing code that is never used.