From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK7wt-0004t1-8C for qemu-devel@nongnu.org; Mon, 25 Mar 2013 10:00:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK7wq-0003wm-MB for qemu-devel@nongnu.org; Mon, 25 Mar 2013 10:00:31 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:43855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK7wq-0003wi-Fk for qemu-devel@nongnu.org; Mon, 25 Mar 2013 10:00:28 -0400 Received: by mail-wi0-f178.google.com with SMTP id ez12so2059904wid.5 for ; Mon, 25 Mar 2013 07:00:27 -0700 (PDT) Date: Mon, 25 Mar 2013 15:00:24 +0100 From: Stefan Hajnoczi Message-ID: <20130325140024.GA3267@stefanha-thinkpad.redhat.com> References: <1363867631-5859-1-git-send-email-pl@kamp.de> <1363867631-5859-2-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363867631-5859-2-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCH 2/2] vl.c: throw an error if iscsi is not supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: qemu-devel@nongnu.org On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote: > this patch adds a check for qemu_find_opts("iscsi") returning > NULL instead of blindly passing the result to qemu_opts_parse(). > > Signed-off-by: Peter Lieven > --- > vl.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Why is this change necessary? Stefan