From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UK9VN-0005MU-LR
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:40:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UK9VH-0006hG-UV
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:40:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UK9Mi-0003T4-QZ
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 11:31:16 -0400
Date: Mon, 25 Mar 2013 16:31:01 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130325163101.39d0cfa4@nial.usersys.redhat.com>
In-Reply-To: <514BC621.8090806@redhat.com>
References: <1363876125-8264-1-git-send-email-imammedo@redhat.com>
	<1363876125-8264-13-git-send-email-imammedo@redhat.com>
	<514BC621.8090806@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/12] target-i386: implement CPU hot-add
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, yang.z.zhang@intel.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, rth@twiddle.net

On Thu, 21 Mar 2013 20:46:57 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 03/21/2013 08:28 AM, Igor Mammedov wrote:
> > ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> > for x86 target.
> > 
> > * add extra check that APIC ID is in allowed range
> 
> > +    if (x86_cpu_is_cpu_exist(qdev_get_machine(), &apic_id)) {
> > +        error_setg(errp, "Unable to add CPU with ID: 0x%" PRIx64
> > +                   ", it's already exists", apic_id);
> 
> s/it's/it/
> 

fixed on WIP branch:
https://github.com/imammedo/qemu/tree/cpu_set.WIP

Thanks!