From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: fred.konrad@greensocs.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] Monitor: Make output buffer dynamic
Date: Mon, 25 Mar 2013 17:44:47 -0400 [thread overview]
Message-ID: <20130325174447.0aac491a@redhat.com> (raw)
In-Reply-To: <5150BC98.5060906@redhat.com>
On Mon, 25 Mar 2013 22:07:36 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 25/03/2013 20:40, Luiz Capitulino ha scritto:
> > Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush()
> > to retry on qemu_chr_fe_write() errors. However, the Monitor's output
> > buffer can keep growing while the retry is not issued and this can
> > cause the buffer to overflow.
> >
> > To reproduce this issue, just start qemu and type on the Monitor:
> >
> > (qemu) ?
> >
> > This will cause the assertion to trig.
> >
> > To fix this problem this commit makes the Monitor buffer dynamic,
> > which means that it can grow as much as needed.
>
> What about using a GString instead?
Makes no difference for me (although I don't enjoy mixing QString and GString
in the same module), but if we do this with the goal of stopping QString
proliferation then we should note somewhere that it shouldn't be used in
new code anymore.
next prev parent reply other threads:[~2013-03-25 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 19:40 [Qemu-devel] [PATCH 0/2] Monitor: make output buffer dynamic Luiz Capitulino
2013-03-25 19:40 ` [Qemu-devel] [PATCH 1/2] qstring: add qobject_get_length() Luiz Capitulino
2013-04-09 3:02 ` Hu Tao
2013-04-09 12:38 ` Luiz Capitulino
2013-03-25 19:40 ` [Qemu-devel] [PATCH 2/2] Monitor: Make output buffer dynamic Luiz Capitulino
2013-03-25 21:07 ` Paolo Bonzini
2013-03-25 21:44 ` Luiz Capitulino [this message]
2013-03-27 6:45 ` Wenchao Xia
2013-03-27 12:27 ` Luiz Capitulino
2013-03-28 3:21 ` Wenchao Xia
2013-04-02 9:18 ` Gerd Hoffmann
2013-04-02 9:19 ` [Qemu-devel] [PATCH 0/2] Monitor: make " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130325174447.0aac491a@redhat.com \
--to=lcapitulino@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).