From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UKDPa-0004Mf-Jk
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:50:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UKDPZ-0003Mt-Dq
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:50:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39477)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1UKDPZ-0003Lp-6C
	for qemu-devel@nongnu.org; Mon, 25 Mar 2013 15:50:29 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2PJoSeX008104
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Mar 2013 15:50:28 -0400
Date: Mon, 25 Mar 2013 20:50:25 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130325195025.GD24866@dhcp-200-207.str.redhat.com>
References: <1364232620-5293-1-git-send-email-kwolf@redhat.com>
	<1364232620-5293-17-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1364232620-5293-17-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 16/19] qcow2: Use byte granularity in
 qcow2_alloc_cluster_offset()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com

Am 25.03.2013 um 18:30 hat Kevin Wolf geschrieben:
> This gets rid of the nb_clusters and keep_clusters and the associated
> complicated calculations. Just advance the number of bytes that have
> been processed and everything is fine.
> 
> This patch advances the variables even after the last operation even
> though they aren't used any more afterwards to make things look more
> uniform. A later patch will turn the whole thing into a loop and then
> it actually starts making sense.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

For the record: This is the one that causes the performance regression.
I'll look into it in more detail tomorrow.

Kevin