From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] block: Add support for Secure Shell (ssh) block device.
Date: Tue, 26 Mar 2013 17:23:03 +0100 [thread overview]
Message-ID: <20130326162303.GB3391@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20130326142139.GC26045@rhmail.home.annexia.org>
On Tue, Mar 26, 2013 at 02:21:39PM +0000, Richard W.M. Jones wrote:
> On Tue, Mar 26, 2013 at 10:38:46AM +0000, Richard W.M. Jones wrote:
> > + /* According to the docs, this just updates a field in the
> > + * sftp_handle structure, so there is no network traffic and it
> > + * cannot fail.
> > + */
> > + libssh2_sftp_seek64(s->sftp_handle, offset);
>
> While I was looking at the performance of qemu+ssh vs sshfs, I noticed
> that the line above has a catastrophic effect on performance, since it
> causes all readahead data to be thrown away. Ooops. I'm reworking
> the patch to make seeking more intelligent.
Should libssh2 be smarter and preserve the readahead when offsets are
contiguous?
It makes sense to fix in QEMU for older libssh2 binaries, but the real
fix might be for libssh2 to be smart.
Stefan
next prev parent reply other threads:[~2013-03-26 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 10:38 [Qemu-devel] [PATCH v3] block: Add support for Secure Shell (ssh) block device Richard W.M. Jones
2013-03-26 14:21 ` Richard W.M. Jones
2013-03-26 16:23 ` Stefan Hajnoczi [this message]
2013-03-26 17:00 ` Richard W.M. Jones
2013-03-26 19:34 ` Richard W.M. Jones
2013-03-27 6:35 ` Stefan Hajnoczi
2013-03-27 15:12 ` Anthony Liguori
2013-03-27 15:44 ` Richard W.M. Jones
2013-03-27 16:43 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326162303.GB3391@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).