From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKXHT-0005fr-Qp for qemu-devel@nongnu.org; Tue, 26 Mar 2013 13:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKXHS-0005Xp-7d for qemu-devel@nongnu.org; Tue, 26 Mar 2013 13:03:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKXHR-0005Xl-Ua for qemu-devel@nongnu.org; Tue, 26 Mar 2013 13:03:26 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2QH3Puo017140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 Mar 2013 13:03:25 -0400 Date: Tue, 26 Mar 2013 18:03:22 +0100 From: Igor Mammedov Message-ID: <20130326180322.6af95956@thinkpad.mammed.net> In-Reply-To: <5151D2CF.9000505@redhat.com> References: <1364316462-3383-1-git-send-email-imammedo@redhat.com> <5151D2CF.9000505@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/12 v3] qmp: add cpu-add qmp command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On Tue, 26 Mar 2013 10:54:39 -0600 Eric Blake wrote: > On 03/26/2013 10:47 AM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > v3: > > * it appears that 'online/offline' in cpu-set are confusing people > > with what command actually does and users might have to distinguish > > if 'offline' is not implemented by parsing error message. To simplify > > things replace cpu-set with cpu-add command to show more clear what > > command does and just add cpu-del when CPU remove is implemented. > > > > v2: > > * s/cpu_set/cpu-set/ > > * qmp doc style fix > > * use bool type instead of opencodding online/offline string > > suggested-by: Eric Blake > > --- > > include/sysemu/sysemu.h | 2 ++ > > qapi-schema.json | 11 +++++++++++ > > qmp-commands.hx | 23 +++++++++++++++++++++++ > > qmp.c | 5 +++++ > > stubs/Makefile.objs | 1 + > > stubs/do_cpu_hot_add.c | 7 +++++++ > > 6 files changed, 49 insertions(+) > > create mode 100644 stubs/do_cpu_hot_add.c > > Reviewed-by: Eric Blake > > I didn't look at the rest of your series (I guess the remaining patches > were only posted in v1?) Yes, remaining patches in RFC v1. Sorry, I've forgot to add reference when posting this patch to stick it in related mail thread. Also there is updated git tree https://github.com/imammedo/qemu/tree/cpu_set.WIP with this patch. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Regards, Igor