From: Stefan Hajnoczi <stefanha@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
david.pravec@nethost.cz, Juan Quintela <quintela@redhat.com>,
mprivozn@redhat.com, Corey Bryant <coreyb@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors
Date: Wed, 27 Mar 2013 09:51:56 +0100 [thread overview]
Message-ID: <20130327085156.GA14550@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <CAJnKYQ=3UdAxhVvgj42ETMsgVxOme5641WAaUQUOhpOQ5Aod0Q@mail.gmail.com>
On Wed, Mar 27, 2013 at 04:37:52PM +0800, liu ping fan wrote:
> On Wed, Mar 27, 2013 at 12:07 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > There are several places where QEMU accidentally relies on the O_NONBLOCK state
> > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the QMP
>
> If in future, we push more backend on their dedicated thread, will the
> related fd be block?
This series is not related to threading in QEMU. The convention it
establishes is that passed fds are blocking. If QEMU wants to use
nonblocking it must call qemu_set_block(fd). This works whether it is
done from a traditional QEMU thread or a data plane thread.
Stefan
next prev parent reply other threads:[~2013-03-27 8:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 16:07 [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds Stefan Hajnoczi
2013-03-26 16:25 ` Juan Quintela
2013-03-27 6:36 ` Stefan Hajnoczi
2013-03-26 16:33 ` Eric Blake
2013-03-27 6:37 ` Stefan Hajnoczi
2013-03-26 16:07 ` [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() Stefan Hajnoczi
2013-03-26 16:33 ` Juan Quintela
2013-03-26 16:34 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 3/4] oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() Stefan Hajnoczi
2013-03-26 16:34 ` Juan Quintela
2013-03-26 16:39 ` Eric Blake
2013-03-26 16:07 ` [Qemu-devel] [PATCH 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors Stefan Hajnoczi
2013-03-26 16:38 ` Juan Quintela
2013-03-26 16:40 ` Eric Blake
2013-03-27 8:37 ` [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed " liu ping fan
2013-03-27 8:51 ` Stefan Hajnoczi [this message]
2013-03-27 13:06 ` Juan Quintela
2013-03-27 13:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327085156.GA14550@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=david.pravec@nethost.cz \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).