From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UKrvk-00050z-Cf
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:06:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UKrvj-0000HF-1N
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:06:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28170)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UKrvi-0000H4-Pq
	for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:06:22 -0400
Date: Wed, 27 Mar 2013 17:06:15 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20130327150615.GB30592@garlic.tlv.redhat.com>
References: <1363612272-13713-1-git-send-email-alevy@redhat.com>
	<1363612272-13713-19-git-send-email-alevy@redhat.com>
	<CAJ+F1C+KGJdxnf1De+ySEF2d-UyeayPMDJL=MQU+pd_A4sriaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1C+KGJdxnf1De+ySEF2d-UyeayPMDJL=MQU+pd_A4sriaA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 18/26] hw/usb/dev-smartcard-reader.c: copy
 atr's protocol to ccid's parameters (adds todo's)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: mlureau@redhat.com, qemu-devel@nongnu.org

On Fri, Mar 22, 2013 at 03:23:15PM +0100, Marc-Andr=E9 Lureau wrote:
> Hi,
>=20
>=20
> On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy <alevy@redhat.com> wrote:
> > +    if (atr_protocol_num =3D=3D 0) {
> > +        DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T0 paramete=
rs"
> > +                " setting\n", __func__);
> > +        t0->bmFindexDindex =3D 0;
> > +        t0->bmTCCKST0 =3D 0;
> > +        t0->bGuardTimeT0 =3D 0;
> > +        t0->bWaitingIntegerT0 =3D 0;
> > +        t0->bClockStop =3D 0;
> > +    } else {
> > +        if (atr_protocol_num !=3D 1) {
> > +            DPRINTF(s, D_WARN, "%s: error: unsupported ATR protocol =
%d\n",
> > +                    __func__, atr_protocol_num);
> > +        } else {
> > +            DPRINTF(s, D_WARN, "%s: error: unimplemented ATR T1 para=
meters"
> > +                    " setting\n", __func__);
> > +            t1->bmFindexDindex =3D 0;
> > +            t1->bmTCCKST1 =3D 0;
> > +            t1->bGuardTimeT1 =3D 0;
> > +            t1->bWaitingIntegerT1 =3D 0;
> > +            t1->bClockStop =3D 0;
> > +            t1->bIFSC =3D 0;
> > +            t1->bNadValue =3D 0;
> > +        }
> > +    }
>=20
> Those blocks could be at the same indentation level, or perhaps use a s=
witch?

A switch is a good idea.

>=20
> Is it sensible to warn in all cases?

Turning them into TODO comments instead (except for the now default
case).

>=20
> --=20
> Marc-Andr=E9 Lureau
>=20