From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKs5k-0003AK-0s for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:16:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKs5e-0004FY-UC for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:16:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKs5e-0004FM-MV for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:16:38 -0400 Date: Wed, 27 Mar 2013 16:16:24 +0100 From: Igor Mammedov Message-ID: <20130327161624.4a56613a@nial.usersys.redhat.com> In-Reply-To: <51530286.0@suse.de> References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-6-git-send-email-imammedo@redhat.com> <5152D180.8030800@redhat.com> <20130327131239.3de95ac3@nial.usersys.redhat.com> <5152E369.6070202@suse.de> <20130327142752.416c3828@nial.usersys.redhat.com> <51530286.0@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, yang.z.zhang@intel.com, Paolo Bonzini , lcapitulino@redhat.com, rth@twiddle.net On Wed, 27 Mar 2013 15:30:30 +0100 Andreas F=E4rber wrote: > Am 27.03.2013 14:27, schrieb Igor Mammedov: > > On Wed, 27 Mar 2013 13:17:45 +0100 > > Andreas F=E4rber wrote: > >>> Then I should move following parts to superclass: > >>> > >>> if (dev->hotplugged) { > >>> cpu_synchronize_post_init(env); > >>> resume_vcpu(CPU(cpu)); > >>> } > >>> > >>> because in case of KVM we should make sure that CPU in sane state bef= ore > >>> allowing CPU to become run-able. > >> > >> That's not possible until we change cpu_synchronize_post_init() argume= nt > >> to CPUState, which is somewhere down my TODO list. Currently I have > >> mostly flushed my refactorings out, so if you wanted to dive into that, > >> that would be appreciated. :) > >=20 > > Would something like this be acceptable? > > --- > > From 15502168009b7b5ae2b46d854c461e5ad031cdc6 Mon Sep 17 00:00:00 2001 > > From: Igor Mammedov > > Date: Wed, 27 Mar 2013 14:21:20 +0100 > > Subject: [PATCH] cpu: Pass CPUState to *cpu_synchronize_post*() > >=20 > > Signed-off-by: Igor Mammedov > > --- > > cpus.c | 4 ++-- > > include/sysemu/kvm.h | 12 ++++++------ > > kvm-all.c | 8 ++------ > > kvm-stub.c | 4 ++-- > > 4 files changed, 12 insertions(+), 16 deletions(-) >=20 > Looks good so far, did you grep for further occurrences? yep, I re-factored every *cpu_synchronize_post*() call, but considering an intention to call cpu_synchronize_post_init() from qom/cpu.c this patch won't work nice since it will pull with itself kvm-stub.o to *-user target. Due to qom/cpu.c is built only once for both softmmu and *-user targets, I consider to move cpu_synchronize_post_init() & cpu_synchronize_post_reset() from include/sysemu/kvm.h into include/sysemu/cpus.h with definition moved into cpus.c + stubs for cpu_synchronize_post_init() &resume_vcpu() in libqemustub for *-user target. Adding stubs to libqemustub could be avoided if resume_vcpu() and cpu_synchronize_post_init() are called from x86_cpu_realizefn() at the cost of some ifdeffenery in include/sysemu/cpus.h though. But moving resume_vcpu() & cpu_synchronize_post_init() into qom/cpu.c looks like good candidate for being reused by other targets.=20 Paolo, would it be acceptable to add resume_vcpu() & cpu_synchronize_post_init() stubs into libqemustub?=20 > Andreas >=20