From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwIg-0006B8-Ep for qemu-devel@nongnu.org; Wed, 27 Mar 2013 15:46:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKwIf-0001un-3T for qemu-devel@nongnu.org; Wed, 27 Mar 2013 15:46:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwIe-0001uT-Rl for qemu-devel@nongnu.org; Wed, 27 Mar 2013 15:46:21 -0400 Date: Wed, 27 Mar 2013 20:46:03 +0100 From: Igor Mammedov Message-ID: <20130327204603.5aa85c3a@thinkpad.mammed.net> In-Reply-To: <51530E2F.2040707@redhat.com> References: <1363876125-8264-1-git-send-email-imammedo@redhat.com> <1363876125-8264-6-git-send-email-imammedo@redhat.com> <5152D180.8030800@redhat.com> <20130327131239.3de95ac3@nial.usersys.redhat.com> <5152E369.6070202@suse.de> <20130327142752.416c3828@nial.usersys.redhat.com> <51530286.0@suse.de> <20130327161624.4a56613a@nial.usersys.redhat.com> <51530E2F.2040707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, yang.z.zhang@intel.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, stefano.stabellini@eu.citrix.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, armbru@redhat.com, blauwirbel@gmail.com, quintela@redhat.com, alex.williamson@redhat.com, kraxel@redhat.com, anthony.perard@citrix.com, lcapitulino@redhat.com, Andreas =?UTF-8?B?RsOkcmJlcg==?= , rth@twiddle.net On Wed, 27 Mar 2013 16:20:15 +0100 Paolo Bonzini wrote: > Il 27/03/2013 16:16, Igor Mammedov ha scritto: > > yep, I re-factored every *cpu_synchronize_post*() call, > > > > but considering an intention to call cpu_synchronize_post_init() from > > qom/cpu.c this patch won't work nice since it will pull with itself > > kvm-stub.o to *-user target. > > > > Due to qom/cpu.c is built only once for both softmmu and *-user targets, I > > consider to move cpu_synchronize_post_init() & cpu_synchronize_post_reset() > > from include/sysemu/kvm.h into include/sysemu/cpus.h with definition moved > > into cpus.c + stubs for cpu_synchronize_post_init() &resume_vcpu() in > > libqemustub for *-user target. > > Adding stubs to libqemustub could be avoided if resume_vcpu() and > > cpu_synchronize_post_init() are called from x86_cpu_realizefn() > > at the cost of some ifdeffenery in include/sysemu/cpus.h though. > > > > But moving resume_vcpu() & cpu_synchronize_post_init() into qom/cpu.c looks > > like good candidate for being reused by other targets. > > > > Paolo, > > would it be acceptable to add resume_vcpu() & cpu_synchronize_post_init() > > stubs into libqemustub? > > Can you instead add all of kvm-stub.c? > > Paolo > It's possible but not all of it, I'll post 3 patches that replace 5/12, linked to this thread. -- Regards, Igor