qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	lf-virt <virtualization@lists.linux-foundation.org>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	target-devel <target-devel@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module
Date: Thu, 28 Mar 2013 00:53:49 +0200	[thread overview]
Message-ID: <20130327225349.GA12927@redhat.com> (raw)
In-Reply-To: <20130327225021.GA12858@redhat.com>

On Thu, Mar 28, 2013 at 12:50:21AM +0200, Michael S. Tsirkin wrote:
> On Wed, Mar 27, 2013 at 03:45:42PM -0700, Nicholas A. Bellinger wrote:
> > On Thu, 2013-03-28 at 00:28 +0200, Michael S. Tsirkin wrote:
> > > On Wed, Mar 27, 2013 at 09:59:45PM +0000, Nicholas A. Bellinger wrote:
> > > > From: Paolo Bonzini <pbonzini@redhat.com>
> > > > 
> > > > The WWPN specified in configfs is passed to "-device vhost-scsi-pci".
> > > > The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not
> > > > available from the QEMU command-line.  Instead, I hardcode it to zero.
> > > > 
> > > > Changes in V4:
> > > >    - Set event_idx=off by default (nab, thanks asias)
> > > 
> > > Why? What's going on here?
> > > 
> > 
> > Not disabling event_idx by default, or disabling from the command line
> > ends up resulting in ->handle_kick() not getting called for subsequent
> > commands..
> > 
> > I spent some time trying to track this down recently with no luck, and
> > AFAICT it's always been required in order for vhost-scsi to function.
> 
> Hmm this is a bug in kernel then. A better work-around is
> to disable EVENT_IDX in kernel. Let's do it for 3.9?

But before we do, can you check that SET_FEATURES is
called with this bit set if you enable event_idx?
If not that's your bug then ...

-- 
MST

  reply	other threads:[~2013-03-27 22:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 21:59 [Qemu-devel] [PATCH 0/3] Add support for vhost-scsi-pci Nicholas A. Bellinger
2013-03-27 21:59 ` [Qemu-devel] [PATCH 1/3] virtio-scsi: create VirtIOSCSICommon Nicholas A. Bellinger
2013-03-27 21:59 ` [Qemu-devel] [PATCH 2/3] vhost-scsi: new device supporting the tcm_vhost Linux kernel module Nicholas A. Bellinger
2013-03-27 22:28   ` Michael S. Tsirkin
2013-03-27 22:45     ` Nicholas A. Bellinger
2013-03-27 22:50       ` Michael S. Tsirkin
2013-03-27 22:53         ` Michael S. Tsirkin [this message]
2013-03-27 23:24           ` Nicholas A. Bellinger
2013-03-28  0:21             ` Nicholas A. Bellinger
2013-03-28  6:19             ` Michael S. Tsirkin
2013-03-28  6:28               ` Nicholas A. Bellinger
2013-03-28 16:54                 ` Michael S. Tsirkin
2013-03-27 23:05         ` Nicholas A. Bellinger
2013-03-27 21:59 ` [Qemu-devel] [PATCH 3/3] vhost: Only call vhost_verify_ring_mappings when adding vhost memory Nicholas A. Bellinger
2013-03-27 22:15   ` Michael S. Tsirkin
2013-03-27 22:16 ` [Qemu-devel] [PATCH 0/3] Add support for vhost-scsi-pci Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130327225349.GA12927@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=asias@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).