From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAiI-0005CN-DO
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:09:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAiF-00044q-Ez
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:09:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAiF-00044W-8T
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:09:43 -0400
Date: Thu, 28 Mar 2013 12:09:37 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130328110937.GC3077@dhcp-200-207.str.redhat.com>
References: <1363961953-13561-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1363961953-13561-18-git-send-email-xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363961953-13561-18-git-send-email-xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b
	for info block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com

Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben:
>   With these parameters, user can choose the information to be showed,
> to avoid message flood in the montior.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

Aha, so here you actually introduce the 'device' parameter. If you can
have this patch first, and only then patch 16, then limiting the new
output to the form with a device specified should be trivial.

> --- a/monitor.c
> +++ b/monitor.c
> @@ -2455,9 +2455,10 @@ static mon_cmd_t info_cmds[] = {
>      },
>      {
>          .name       = "block",
> -        .args_type  = "",
> -        .params     = "",
> -        .help       = "show the block devices",
> +        .args_type  = "backing:-b,device:B?",
> +        .params     = "[-b] [device]",
> +        .help       = "show info of one block device or all block devices "
> +                      "[and info of backing images with -b option",

That '[' doesn't look intentional?

Kevin