From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ULHhY-0000qB-9N
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 14:37:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ULHhX-0006O5-8U
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 14:37:28 -0400
Received: from ssl.serverraum.org ([88.198.40.39]:36621)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1ULHhW-0006Kk-Jx
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 14:37:27 -0400
From: Michael Walle <michael@walle.cc>
Date: Thu, 28 Mar 2013 19:37:03 +0100
References: <1363358063-23973-1-git-send-email-peter.maydell@linaro.org>
	<201303281931.21945.michael@walle.cc>
	<CAFEAcA9H=_HYD_CngoUVHVexx8k6WPV+ef1PjsyEZ90A5PUhDQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9H=_HYD_CngoUVHVexx8k6WPV+ef1PjsyEZ90A5PUhDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201303281937.03817.michael@walle.cc>
Subject: Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM
	memory regions in the device itself
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: patches@linaro.org, qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@web.de>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?q?F=C3=A4rber?= <afaerber@suse.de>

Am Donnerstag 28 M=C3=A4rz 2013, 19:33:48 schrieb Peter Maydell:
> On 28 March 2013 18:31, Michael Walle <michael@walle.cc> wrote:
> > Am Donnerstag 28 M=C3=A4rz 2013, 18:55:59 schrieb Anthony Liguori:cc>
> >=20
> >> Breaks the build:
> >>=20
> >> [aliguori@ccnode4 qemu]$ make
> >>=20
> >>   CC    lm32-softmmu/hw/lm32/../milkymist-softusb.o
> >>=20
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> >> =E2=80=98softusb_mouse_hid_datain=E2=80=99:
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:183:38: error:
> >> =E2=80=98m=E2=80=99 may be used uninitialized in this function
> >> [-Werror=3Dmaybe-uninitialized]
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:179:13: note:
> >> =E2=80=98m=E2=80=99 was declared here
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> >> =E2=80=98softusb_kbd_hid_datain=E2=80=99:
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:197:38: error:
> >> =E2=80=98m=E2=80=99 may be used uninitialized in this function
> >> [-Werror=3Dmaybe-uninitialized]
> >> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:193:13: note:
> >> =E2=80=98m=E2=80=99 was declared here cc1: all warnings being treated =
as errors
> >> make[1]: *** [hw/lm32/../milkymist-softusb.o] Error 1
> >=20
> > are you sure, this patch breaks the build, or was is broken before?
> >=20
> > i'll send a patch soon.
>=20
> My compiler doesn't complain. I suspect you may be right and
> the problem was already there. Anyway I think that adding
> a 'memset(buf, 0, len);' after the error_report() calls
> in softusb_read_pmem()/softusb_read_dmem() will fix it.

Sounds good. Are you fixing it, or should i send a patch?

=2D-=20
michael