From: Aurelien Jarno <aurelien@aurel32.net>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions
Date: Fri, 29 Mar 2013 07:56:25 +0100 [thread overview]
Message-ID: <20130329065625.GF5000@ohm.aurel32.net> (raw)
In-Reply-To: <20130328234648.GA4021@smtp.vpn>
On Fri, Mar 29, 2013 at 12:46:49AM +0100, Edgar E. Iglesias wrote:
> On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote:
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Hi Aurelien,
>
> Nice patches!
>
> A question - The sbox tables are already available but in
> a different format in util/aes.c. Would it make sense to
> reuse (see Te4 and Td4) ?
>
It looks like it's possible to reuse the Te4 and Td4 tables from there,
it should also be possible to used Te0-Te3 for aesenc and Td0-Td3 for
aesdec. That said it might not simplify the code a lot, as aesimc and
aeskeygenassist are only doing part of the aes process.
I will look at that more in details later and I will try to come with
a solution to reuse the code from aes.c.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2013-03-29 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 23:36 [Qemu-devel] [PATCH v2 0/3] target-i386: add PCLMULQDQ and AES-NI instructions Aurelien Jarno
2013-03-28 23:36 ` [Qemu-devel] [PATCH v2 1/3] target-i386: add pclmulqdq instruction Aurelien Jarno
2013-03-28 23:36 ` [Qemu-devel] [PATCH v2 2/3] target-i386: enable PCLMULQDQ on Westmere CPU Aurelien Jarno
2013-03-28 23:36 ` [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions Aurelien Jarno
2013-03-28 23:46 ` Edgar E. Iglesias
2013-03-29 6:56 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130329065625.GF5000@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).