From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULXv4-0002r1-GI for qemu-devel@nongnu.org; Fri, 29 Mar 2013 07:56:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULXv3-0001wm-94 for qemu-devel@nongnu.org; Fri, 29 Mar 2013 07:56:30 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:36886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULXv3-0001w7-2D for qemu-devel@nongnu.org; Fri, 29 Mar 2013 07:56:29 -0400 Date: Fri, 29 Mar 2013 07:56:25 +0100 From: Aurelien Jarno Message-ID: <20130329065625.GF5000@ohm.aurel32.net> References: <1364513790-5421-1-git-send-email-aurelien@aurel32.net> <1364513790-5421-4-git-send-email-aurelien@aurel32.net> <20130328234648.GA4021@smtp.vpn> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20130328234648.GA4021@smtp.vpn> Subject: Re: [Qemu-devel] [PATCH v2 3/3] target-i386: add AES-NI instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: qemu-devel@nongnu.org On Fri, Mar 29, 2013 at 12:46:49AM +0100, Edgar E. Iglesias wrote: > On Fri, Mar 29, 2013 at 12:36:29AM +0100, Aurelien Jarno wrote: > > Signed-off-by: Aurelien Jarno > > Hi Aurelien, > > Nice patches! > > A question - The sbox tables are already available but in > a different format in util/aes.c. Would it make sense to > reuse (see Te4 and Td4) ? > It looks like it's possible to reuse the Te4 and Td4 tables from there, it should also be possible to used Te0-Te3 for aesenc and Td0-Td3 for aesdec. That said it might not simplify the code a lot, as aesimc and aeskeygenassist are only doing part of the aes process. I will look at that more in details later and I will try to come with a solution to reuse the code from aes.c. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net