From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULTVJ-0005Xk-9R for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULTVG-0004jS-W0 for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:13:37 -0400 Received: from [222.73.24.84] (port=15953 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULTVG-0004ib-Lx for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:13:34 -0400 Date: Fri, 29 Mar 2013 15:12:51 +0800 From: Hu Tao Message-ID: <20130329071251.GE3060@localhost.localdomain> References: <5151B998.6080907@redhat.com> <1364451363-25763-1-git-send-email-hutao@cn.fujitsu.com> <515434A0.5090706@redhat.com> MIME-Version: 1.0 In-Reply-To: <515434A0.5090706@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: Re: [Qemu-devel] [PATCH v15.2 4/6] pvpanic: add document of pvpanic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , qemu-devel On Thu, Mar 28, 2013 at 06:16:32AM -0600, Eric Blake wrote: > On 03/28/2013 12:16 AM, Hu Tao wrote: > > Signed-off-by: Hu Tao > > --- > > docs/specs/pvpanic.txt | 37 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 docs/specs/pvpanic.txt > > One typo remaining: > > > +ACPI Interface > > +-------------- > > + > > +pvpanic device is defined with ACPI ID "QEMU0001". Custom methods: > > + > > +RDPT: To determine whether guest panic notification is supported. > > +Rrguments: None > > s/Rrguments/Arguments/ > > I think that can be fixed by whoever merges and sends the pull request, > without needing you to do a respin. With that fixed, you have: > > Reviewed-by: Eric Blake Thanks for review! -- Regards, Hu Tao