From: Amit Shah <amit.shah@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-char: rewrite io_channel_send_all and drop the '_all' suffix
Date: Mon, 1 Apr 2013 12:17:28 +0530 [thread overview]
Message-ID: <20130401064728.GA3745@amit.redhat.com> (raw)
In-Reply-To: <1364575190-731-1-git-send-email-aliguori@us.ibm.com>
On (Fri) 29 Mar 2013 [11:39:50], Anthony Liguori wrote:
> The current code is oddly written and have equally odd semantics.
> Despite the '_all' suffix, upon EAGAIN the result will be a partial
> write but instead of returning the partial write, we return EAGAIN.
>
> Change the behavior to write as much as we can until we get an EAGAIN
> returning a partial write if we do.
>
> Reported-by: Amit Shah <amit.shah@redhat.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Looks good.
Tested-by: Amit Shah <amit.shah@redhat.com>
Amit
next prev parent reply other threads:[~2013-04-01 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 16:39 [Qemu-devel] [PATCH] qemu-char: rewrite io_channel_send_all and drop the '_all' suffix Anthony Liguori
2013-04-01 6:47 ` Amit Shah [this message]
2013-04-02 20:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401064728.GA3745@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).