From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMYWl-0004g0-06 for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMYWj-0000gz-Ld for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:47:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMYWj-0000gs-DY for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:47:33 -0400 Date: Mon, 1 Apr 2013 12:17:28 +0530 From: Amit Shah Message-ID: <20130401064728.GA3745@amit.redhat.com> References: <1364575190-731-1-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364575190-731-1-git-send-email-aliguori@us.ibm.com> Subject: Re: [Qemu-devel] [PATCH] qemu-char: rewrite io_channel_send_all and drop the '_all' suffix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On (Fri) 29 Mar 2013 [11:39:50], Anthony Liguori wrote: > The current code is oddly written and have equally odd semantics. > Despite the '_all' suffix, upon EAGAIN the result will be a partial > write but instead of returning the partial write, we return EAGAIN. > > Change the behavior to write as much as we can until we get an EAGAIN > returning a partial write if we do. > > Reported-by: Amit Shah > Signed-off-by: Anthony Liguori Looks good. Tested-by: Amit Shah Amit