From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMYfW-0007Lk-Ms for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:56:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMYfV-00036r-Jf for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMYfV-00036n-AQ for qemu-devel@nongnu.org; Mon, 01 Apr 2013 02:56:37 -0400 Date: Mon, 1 Apr 2013 12:26:16 +0530 From: Amit Shah Message-ID: <20130401065616.GA21467@amit.redhat.com> References: <20130312213129.25163.84447.malonedeb@gac.canonical.com> <20130312213129.25163.84447.malonedeb@gac.canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130312213129.25163.84447.malonedeb@gac.canonical.com> Subject: Re: [Qemu-devel] [Bug 1154328] [NEW] qemu locks up on typing 41 characters at once into serial console List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bug 1154328 <1154328@bugs.launchpad.net> Cc: Anthony Liguori , qemu-devel@nongnu.org, aurelien@aurel32.net On (Tue) 12 Mar 2013 [21:31:29], Andreas Gustafsson wrote: > Now cut-and-paste a string containing at least 41 characters into the > terminal window. I used a string containing 41 copies of the letter > "X". You can use other strings, but beware of pasting strings > containing valid shell commands, as they may end up being executed on > the host (see below). > > If your copy of qemu is suffering from the bug, it will lock up. Not > only will the virtual machine no longer respond to keystrokes, but > qemu itself will no longer respond to commands such as "control-a c". > You will have to kill it from a different terminal window. When the > qemu process is killed, any pasted characters after the first 40 will > be read and executed by the host shell, suggesting that they were never > even read by the qemu process. As I had typed a return after pasting > the 41 X:es, the host shell executed the command "X", thereby > accidentally attempting (unsuccessfully) to start an X server. > > "git bisect" implicates the following commit: > > commit a29753f8aa79a34a324afebe340182a51a5aef11 > Author: Anthony Liguori > Date: Tue Mar 5 23:21:19 2013 +0530 > > qemu-char: convert fd_chr to use a GIOChannel > > This uses the newly introduced IOWatchPoll source. Does [PATCH] qemu-char: rewrite io_channel_send_all and drop the '_all' suffix that's on the list help? If not, does reverting fcfb4d6aae611d1f804d486d3c998000912c4c81 help? (That is "serial: add flow control to transmit"). Amit