From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMvv1-0007WG-0r for qemu-devel@nongnu.org; Tue, 02 Apr 2013 03:46:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMvuz-0002EV-Rv for qemu-devel@nongnu.org; Tue, 02 Apr 2013 03:46:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMvuz-0002ER-JE for qemu-devel@nongnu.org; Tue, 02 Apr 2013 03:46:09 -0400 Date: Tue, 2 Apr 2013 09:46:04 +0200 From: Kevin Wolf Message-ID: <20130402074604.GB2341@dhcp-200-207.str.redhat.com> References: <1363961953-13561-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363961953-13561-18-git-send-email-xiawenc@linux.vnet.ibm.com> <20130328110937.GC3077@dhcp-200-207.str.redhat.com> <5155010F.9040305@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5155010F.9040305@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com Am 29.03.2013 um 03:48 hat Wenchao Xia geschrieben: > =E4=BA=8E 2013-3-28 19:09, Kevin Wolf =E5=86=99=E9=81=93: > >Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben: > >> With these parameters, user can choose the information to be showe= d, > >>to avoid message flood in the montior. > >> > >>Signed-off-by: Wenchao Xia > > > >Aha, so here you actually introduce the 'device' parameter. If you can > >have this patch first, and only then patch 16, then limiting the new > >output to the form with a device specified should be trivial. > > > It is a bit indirect that "info block" and "info block " > show different on single device, so I introduced additional parameter > '-b' to filter out info. With more thinking, I think it should be > { > .name =3D "block", > .help =3D "show the block devices", > .args_type =3D "verbose:-v,device:B?", > .params =3D "[-v] [device]", > .help =3D "show info of one block device or all block dev= ices " > "and detail of images with -v option", > } > Then by default "info block" so brief summary as old time. Since the > "-v" parameter is filtering something out not present on patch 15, > so I can't move this patch forward, hope you are OK with it. 'info block [-v] []' is okay with me. I would prefer if you could arrange the patches so that without -v you never get verbose output in any intermediate patch, but otherwise I don't mind about the order of patches. Kevin