From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMwif-0003zk-V3 for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:37:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMwif-0002aZ-2t for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:37:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMwie-0002aU-SD for qemu-devel@nongnu.org; Tue, 02 Apr 2013 04:37:29 -0400 Date: Tue, 2 Apr 2013 10:37:24 +0200 From: Kevin Wolf Message-ID: <20130402083724.GF2341@dhcp-200-207.str.redhat.com> References: <1364507550-25093-1-git-send-email-aliguori@us.ibm.com> <1364507550-25093-3-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364507550-25093-3-git-send-email-aliguori@us.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH 2/3] sheepdog: pass NULL for io_flush List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org, Mike Roth Am 28.03.2013 um 22:52 hat Anthony Liguori geschrieben: > Signed-off-by: Anthony Liguori > --- > block/sheepdog.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/block/sheepdog.c b/block/sheepdog.c > index bb67c4c..2bccd9b 100644 > --- a/block/sheepdog.c > +++ b/block/sheepdog.c > @@ -503,13 +503,6 @@ static void restart_co_req(void *opaque) > qemu_coroutine_enter(co, NULL); > } > > -static int have_co_req(void *opaque) > -{ > - /* this handler is set only when there is a pending request, so > - * always returns 1. */ Now you return 1 even when no request is pending (which is the case in which no io_flush handler would be set before). Why is this correct? (This is actually a question about PATCH 1/3, I just noticed it here. Are there more cases like this?) Kevin