From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UMzvM-000379-TK
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 08:02:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UMzvG-0008Bd-Oi
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 08:02:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UMzvG-0008B2-GA
	for qemu-devel@nongnu.org; Tue, 02 Apr 2013 08:02:42 -0400
Date: Tue, 2 Apr 2013 15:01:45 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130402120145.GB21545@redhat.com>
References: <1364860704-11896-1-git-send-email-nab@linux-iscsi.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1364860704-11896-1-git-send-email-nab@linux-iscsi.org>
Subject: Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for
	uninitialized VQs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: kvm-devel <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, lf-virt <virtualization@lists.linux-foundation.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, target-devel <target-devel@vger.kernel.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>

On Mon, Apr 01, 2013 at 11:58:21PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> Hi folks,
> 
> This series adds a virtio_queue_valid() for use by virtio-pci code in
> order to prevent opreations upon uninitialized VQs, which is currently
> expected to occur during seabios setup of virtio-scsi with in-flight
> vhost-scsi-pci device code.
> 
> On the vhost side, it also adds virtio_queue_valid() sanity checks in
> vhost_virtqueue_[start,stop]() and vhost_verify_ring_mappings() in order
> to skip the same uninitialized VQs.
> 
> Changes from v1:
>   - Remove now unnecessary virtio_queue_get_num() calls in virtio-pci.c
>   - Add virtio_queue_valid() calls in vhost_virtqueue_[start,stop]()
> 
> Please review.
> 
> --nab

Looks reasonable.
Acked-by: Michael S. Tsirkin <mst@redhat.com>

So - does this fix the issues you saw with vhost-scsi?

> Michael S. Tsirkin (1):
>   virtio: add API to check that ring is setup
> 
> Nicholas Bellinger (2):
>   virtio-pci: Add virtio_queue_valid checks ahead of
>     virtio_queue_get_num
>   vhost: Skip uninitialized VQs in vhost_virtqueue_[start,stop]
> 
>  hw/vhost.c      |   12 ++++++++++++
>  hw/virtio-pci.c |   34 +++++++++++++++-------------------
>  hw/virtio.c     |    5 +++++
>  hw/virtio.h     |    1 +
>  4 files changed, 33 insertions(+), 19 deletions(-)
> 
> -- 
> 1.7.2.5