Re: [Qemu-devel] [PATCH] Add configure clock_gettime() monotonic time test

[Brad Smith <brad@comstyle.com>]

On Tue, Apr 02, 2013 at 06:45:17PM +0200, Paolo Bonzini wrote:
> Il 02/04/2013 17:42, Brad Smith ha scritto:
> > Replace the hardcoded list of OS's utilizing clock_gettime() for monotonic
> > time with a configure test. This is to fix the use of monotonic time on
> > OpenBSD but allows for other POSIX compliant OS's such as NetBSD to also
> > utilize clock_gettime().
> 
> I thought the list of OSes was supposed to filter out those that somehow
> had a broken CLOCK_MONOTONIC.
> 
> Otherwise, you might as well use "#ifdef CLOCK_MONOTONIC" and skip the
> configure test completely.

I only wrote the test as that was what was suggested and even if there
are OS's that have broken monotonic support it is better to put any
exclusion logic in the configure script over having more hardcoded
lists of OS's directly in the code. What OS's have broken monotonic
support?

I would have no problem going in that direction if no one can actually
come up with an OS (or more) that have monotonic support but it is
somehow broken; as in having clock_gettime() and the CLOCK_MONOTONIC
define but not functioning properly.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.