From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNHaC-0005bt-0p for qemu-devel@nongnu.org; Wed, 03 Apr 2013 02:54:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNHa9-0006Af-RK for qemu-devel@nongnu.org; Wed, 03 Apr 2013 02:54:07 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:54788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNHa9-00066Y-JV for qemu-devel@nongnu.org; Wed, 03 Apr 2013 02:54:05 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Apr 2013 07:51:42 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4F3821B08066 for ; Wed, 3 Apr 2013 07:54:00 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r336roOI50790434 for ; Wed, 3 Apr 2013 06:53:50 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r336rxRr018316 for ; Wed, 3 Apr 2013 00:53:59 -0600 Date: Wed, 3 Apr 2013 08:53:57 +0200 From: Cornelia Huck Message-ID: <20130403085357.2d571f86@gondolin> In-Reply-To: <1364547764-6627-2-git-send-email-fred.konrad@greensocs.com> References: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com> <1364547764-6627-2-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: Amit Shah , peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org On Fri, 29 Mar 2013 10:02:38 +0100 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > Create virtio-serial which extends virtio-device, so it can be connected > on virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 2 +- > hw/virtio-serial-bus.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++---- > hw/virtio-serial.h | 9 +++++ > 3 files changed, 98 insertions(+), 8 deletions(-) > > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > index fb20722..6db67bf 100644 > --- a/hw/virtio-pci.c > +++ b/hw/virtio-pci.c > @@ -1075,7 +1075,7 @@ static Property virtio_serial_properties[] = { > DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2), > DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0), > DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features), > - DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, serial.max_virtserial_ports, 31), > + DEFINE_VIRTIO_SERIAL_PROPERTIES(VirtIOPCIProxy, serial), > DEFINE_PROP_END_OF_LIST(), > }; > Any reason why you convert only virtio-pci to the new define? s390-virtio and virtio-ccw could use it as well.