qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com,
	stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction
Date: Wed, 3 Apr 2013 11:03:51 +0200	[thread overview]
Message-ID: <20130403090351.GB2854@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <515BBFB2.2000406@linux.vnet.ibm.com>

Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben:
> 于 2013-4-2 21:59, Kevin Wolf 写道:
> >Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben:
> >>   Last operaton should be cancelled first.
> >>
> >>Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> >
> >Should it? This commit message does little to convince me.
> >
> >Kevin
> >
>   I think so, if two request are "snapshot_blkdev ide0 newimage.qcow2",
> "snapshot_blkdev_internal ide0 snap0", then in rollback delete of
> snap0 would be wrong.

I think this problem exists only because you didn't properly separate
the prepare and the commit stage. If any changes only took effect in a
non-failing commit stage, then you don't ever have to delete a snapshot.
Instead, you just abort the creation of the snapshot.

Kevin

  reply	other threads:[~2013-04-03  9:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 10:01 [Qemu-devel] [PATCH 0/3] block: make qmp_transaction extendable Wenchao Xia
2013-04-01 10:01 ` [Qemu-devel] [PATCH 1/3] block: add function deappend() Wenchao Xia
2013-04-01 10:01 ` [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable Wenchao Xia
2013-04-02 13:55   ` Kevin Wolf
2013-04-03  5:51     ` Wenchao Xia
2013-04-03  7:21       ` Paolo Bonzini
2013-04-03  9:02         ` Wenchao Xia
2013-04-03  9:17           ` Paolo Bonzini
2013-04-03  9:22           ` Kevin Wolf
2013-04-03 10:33           ` Wenchao Xia
2013-04-17 14:42   ` Stefan Hajnoczi
2013-04-18  3:00     ` Wenchao Xia
2013-04-18  6:35       ` Stefan Hajnoczi
2013-04-01 10:01 ` [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction Wenchao Xia
2013-04-01 15:52   ` Eric Blake
2013-04-02  2:34     ` Wenchao Xia
2013-04-02 13:59   ` Kevin Wolf
2013-04-03  5:35     ` Wenchao Xia
2013-04-03  9:03       ` Kevin Wolf [this message]
2013-04-03 10:35         ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130403090351.GB2854@dhcp-200-207.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=dietmar@proxmox.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).