From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1UNJpv-0003jK-Gc
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:18:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1UNJpq-00037M-6w
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:18:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61952)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1UNJpp-00037A-VL
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 05:18:26 -0400
Date: Wed, 3 Apr 2013 14:48:17 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20130403091817.GA15683@amit.redhat.com>
References: <1364547764-6627-1-git-send-email-fred.konrad@greensocs.com>
	<1364547764-6627-3-git-send-email-fred.konrad@greensocs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1364547764-6627-3-git-send-email-fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the
 new API.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org

On (Fri) 29 Mar 2013 [10:02:39], fred.konrad@greensocs.com wrote:
> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> Here the virtio-serial-pci is modified for the new API. The device
> virtio-serial-pci extends virtio-pci. It creates and connects a
> virtio-serial during the init. The properties are not changed.

> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index 6db67bf..83f15b6 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c

> -static Property virtio_serial_properties[] = {
> -    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
> -    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),

[snip]

> +static Property virtio_serial_pci_properties[] = {
> +    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
> +                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
> +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors,
> +                    DEV_NVECTORS_UNSPECIFIED),

The change in commit 554f1997f0328bc259454239db64b20b3376d9a6 got lost
in a rebase -- this should be 2 instead of DEV_NVECTORS_UNSPECIFIED.

		Amit