From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device
Date: Wed, 3 Apr 2013 13:38:46 +0300 [thread overview]
Message-ID: <20130403103846.GB18725@redhat.com> (raw)
In-Reply-To: <515C05B0.2000401@redhat.com>
On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote:
> Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto:
> > > Because someone wasn't looking. :) The hw/ reorganization patches I've
> > > posted fix that.
> >
> > Still not sure how to merge this, if it goes in through my tree
> > and that's the only comment, I'll just fix it silently ...
>
> Indeed. In fact, considering my hw/ reorganization patches will be
> committed soon, please put it in hw/pci (matching hw/isa/pc-testdev.c).
Paolo, hw/pci is pci core, I haven't looked at your reorg patches,
but please do not move devices there.
Sorting devices by connection is also wrong I think, by function
would be better.
> Another comment is that you should add a description in docs/specs.
>
> Paolo
pc-test has none ... I'll see what I can do.
--
MST
next prev parent reply other threads:[~2013-04-03 10:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 8:59 [Qemu-devel] [PATCH 0/4] kvm-unittests: add pci PORT IO and MMIO speed tests Michael S. Tsirkin
2013-04-03 8:59 ` [Qemu-devel] [PATCH 1/4] kvm: remove unused APIs Michael S. Tsirkin
2013-04-03 8:59 ` [Qemu-devel] [PATCH 2/4] kvm: support any size for pio eventfd Michael S. Tsirkin
2013-04-03 8:59 ` [Qemu-devel] [PATCH 3/4] kvm: support non datamatch ioeventfd Michael S. Tsirkin
2013-04-03 8:59 ` [Qemu-devel] [PATCH 4/4] pci: add pci test device Michael S. Tsirkin
2013-04-03 9:28 ` Paolo Bonzini
2013-04-03 9:45 ` Michael S. Tsirkin
2013-04-03 9:53 ` Paolo Bonzini
2013-04-03 10:22 ` Michael S. Tsirkin
2013-04-03 10:25 ` Paolo Bonzini
2013-04-03 10:33 ` Michael S. Tsirkin
2013-04-03 10:34 ` Paolo Bonzini
2013-04-03 10:38 ` Michael S. Tsirkin [this message]
2013-04-03 11:48 ` Paolo Bonzini
2013-04-03 12:00 ` Michael S. Tsirkin
2013-04-03 12:05 ` Paolo Bonzini
2013-04-03 14:06 ` Michael S. Tsirkin
2013-04-03 14:08 ` Paolo Bonzini
2013-04-03 14:28 ` Michael S. Tsirkin
2013-04-03 15:46 ` Paolo Bonzini
2013-04-03 17:04 ` Michael S. Tsirkin
2013-04-03 17:10 ` Paolo Bonzini
2013-04-03 14:33 ` Michael S. Tsirkin
2013-04-03 15:09 ` Michael S. Tsirkin
2013-04-03 15:43 ` Paolo Bonzini
2013-04-03 18:39 ` Michael S. Tsirkin
2013-04-03 19:59 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2013-04-18 8:00 [Qemu-devel] [PULL 0/4] " Michael S. Tsirkin
2013-04-18 8:00 ` [Qemu-devel] [PATCH 4/4] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403103846.GB18725@redhat.com \
--to=mst@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).