From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNL4n-00079o-8r for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:37:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNL4j-0006Aw-Ph for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:37:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNL4j-00069x-Ie for qemu-devel@nongnu.org; Wed, 03 Apr 2013 06:37:53 -0400 Date: Wed, 3 Apr 2013 13:38:46 +0300 From: "Michael S. Tsirkin" Message-ID: <20130403103846.GB18725@redhat.com> References: <515BF657.7000904@redhat.com> <20130403094529.GA18179@redhat.com> <515BFC37.4000802@redhat.com> <20130403102229.GD18179@redhat.com> <515C037E.5030706@redhat.com> <20130403103301.GG18179@redhat.com> <515C05B0.2000401@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515C05B0.2000401@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: gleb@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: > > > Because someone wasn't looking. :) The hw/ reorganization patches I've > > > posted fix that. > > > > Still not sure how to merge this, if it goes in through my tree > > and that's the only comment, I'll just fix it silently ... > > Indeed. In fact, considering my hw/ reorganization patches will be > committed soon, please put it in hw/pci (matching hw/isa/pc-testdev.c). Paolo, hw/pci is pci core, I haven't looked at your reorg patches, but please do not move devices there. Sorting devices by connection is also wrong I think, by function would be better. > Another comment is that you should add a description in docs/specs. > > Paolo pc-test has none ... I'll see what I can do. -- MST