From: Luiz Capitulino <lcapitulino@redhat.com>
To: mdroth <mdroth@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Juan Quintela <quintela@redhat.com>,
mprivozn@redhat.com, coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru,
david.pravec@nethost.cz, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors
Date: Wed, 3 Apr 2013 11:24:38 -0400 [thread overview]
Message-ID: <20130403112438.4fea6cc7@redhat.com> (raw)
In-Reply-To: <20130403150540.GA26115@vm>
On Wed, 3 Apr 2013 10:05:40 -0500
mdroth <mdroth@linux.vnet.ibm.com> wrote:
> On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote:
> > On Wed, 27 Mar 2013 10:10:42 +0100
> > Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > > There are several places where QEMU accidentally relies on the O_NONBLOCK state
> > > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the QMP
> > > API whenever getfd or fdset_add_fd are used!
> > >
> > > Whether or not QEMU will use O_NONBLOCK is an implementation detail and should
> > > be hidden from QMP clients.
> > >
> > > This patch series addresses this in 3 steps:
> >
> > Nice series:
> >
> > Applied to the qmp branch, thanks.
>
> Hi Luiz,
>
> Eric/mjt have noted that this series fixes a number of issues in 1.4.0
> and have requested it for 1.4.1
>
> http://thread.gmane.org/gmane.comp.emulators.qemu/203851
>
> The cut-off for 1.4.1 is Tuesday. Do you plan to send a pull for these soon?
Sure, I can do that. And thanks to remind me.
next prev parent reply other threads:[~2013-04-03 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 9:10 [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors Stefan Hajnoczi
2013-03-27 9:10 ` [Qemu-devel] [PATCH v2 1/4] oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() Stefan Hajnoczi
2013-03-27 9:10 ` [Qemu-devel] [PATCH v2 2/4] net: ensure "socket" backend uses non-blocking fds Stefan Hajnoczi
2013-03-27 9:10 ` [Qemu-devel] [PATCH v2 3/4] qemu-socket: set passed fd non-blocking in socket_connect() Stefan Hajnoczi
2013-03-27 9:10 ` [Qemu-devel] [PATCH v2 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors Stefan Hajnoczi
2013-03-27 11:48 ` [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed " Eric Blake
2013-03-27 13:17 ` Luiz Capitulino
2013-04-03 15:05 ` mdroth
2013-04-03 15:24 ` Luiz Capitulino [this message]
2013-04-03 15:31 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403112438.4fea6cc7@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=david.pravec@nethost.cz \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).