From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNPub-0002Lu-6I for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:47:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNPuY-0002fH-VJ for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:47:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNPuY-0002f6-OB for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:47:42 -0400 Date: Wed, 3 Apr 2013 11:24:38 -0400 From: Luiz Capitulino Message-ID: <20130403112438.4fea6cc7@redhat.com> In-Reply-To: <20130403150540.GA26115@vm> References: <1364375446-24180-1-git-send-email-stefanha@redhat.com> <20130327091730.0c1bfe09@redhat.com> <20130403150540.GA26115@vm> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: Anthony Liguori , Juan Quintela , mprivozn@redhat.com, coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru, david.pravec@nethost.cz, qemu-devel@nongnu.org, Stefan Hajnoczi On Wed, 3 Apr 2013 10:05:40 -0500 mdroth wrote: > On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote: > > On Wed, 27 Mar 2013 10:10:42 +0100 > > Stefan Hajnoczi wrote: > > > > > There are several places where QEMU accidentally relies on the O_NONBLOCK state > > > of passed file descriptors. Exposing O_NONBLOCK state makes it part of the QMP > > > API whenever getfd or fdset_add_fd are used! > > > > > > Whether or not QEMU will use O_NONBLOCK is an implementation detail and should > > > be hidden from QMP clients. > > > > > > This patch series addresses this in 3 steps: > > > > Nice series: > > > > Applied to the qmp branch, thanks. > > Hi Luiz, > > Eric/mjt have noted that this series fixes a number of issues in 1.4.0 > and have requested it for 1.4.1 > > http://thread.gmane.org/gmane.comp.emulators.qemu/203851 > > The cut-off for 1.4.1 is Tuesday. Do you plan to send a pull for these soon? Sure, I can do that. And thanks to remind me.