From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UNPfW-00075h-9E
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:32:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UNPfG-0005Lq-PV
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:32:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UNPfG-0005Ju-Es
	for qemu-devel@nongnu.org; Wed, 03 Apr 2013 11:31:54 -0400
Date: Wed, 3 Apr 2013 11:31:45 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130403113145.675c3a03@redhat.com>
In-Reply-To: <20130403112438.4fea6cc7@redhat.com>
References: <1364375446-24180-1-git-send-email-stefanha@redhat.com>
	<20130327091730.0c1bfe09@redhat.com> <20130403150540.GA26115@vm>
	<20130403112438.4fea6cc7@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/4] monitor: do not rely on O_NONBLOCK
 for passed file descriptors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org, mprivozn@redhat.com, coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru, david.pravec@nethost.cz, mdroth <mdroth@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>

On Wed, 3 Apr 2013 11:24:38 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Wed, 3 Apr 2013 10:05:40 -0500
> mdroth <mdroth@linux.vnet.ibm.com> wrote:
> 
> > On Wed, Mar 27, 2013 at 09:17:30AM -0400, Luiz Capitulino wrote:
> > > On Wed, 27 Mar 2013 10:10:42 +0100
> > > Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > 
> > > > There are several places where QEMU accidentally relies on the O_NONBLOCK state
> > > > of passed file descriptors.  Exposing O_NONBLOCK state makes it part of the QMP
> > > > API whenever getfd or fdset_add_fd are used!
> > > > 
> > > > Whether or not QEMU will use O_NONBLOCK is an implementation detail and should
> > > > be hidden from QMP clients.
> > > > 
> > > > This patch series addresses this in 3 steps:
> > > 
> > > Nice series:
> > > 
> > > Applied to the qmp branch, thanks.
> > 
> > Hi Luiz,
> > 
> > Eric/mjt have noted that this series fixes a number of issues in 1.4.0
> > and have requested it for 1.4.1
> > 
> > http://thread.gmane.org/gmane.comp.emulators.qemu/203851
> > 
> > The cut-off for 1.4.1 is Tuesday. Do you plan to send a pull for these soon?
> 
> Sure, I can do that. And thanks to remind me.

Actually, I can't cherry-pick it cleanly.

Stefan, would you mind to backport this series to v1.4.1 yourself?