From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNOKy-0007Fo-KN for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:06:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNOKv-0007Js-Gj for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:06:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNOKv-0007Jl-8E for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:06:49 -0400 Date: Wed, 3 Apr 2013 17:07:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20130403140740.GD22200@redhat.com> References: <1364914749-11141-1-git-send-email-pbonzini@redhat.com> <20130403104951.GD18803@redhat.com> <515C18BF.40105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515C18BF.40105@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/36] hw/ reorganization, part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Igor Mammedov , qemu-devel@nongnu.org, Andreas Faerber On Wed, Apr 03, 2013 at 01:55:43PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:49, Michael S. Tsirkin ha scritto: > > The idea to sort devices by function makes sense to be. > > But ISA and PCI here are wrong, they try to sort > > things by connection. > > Almost all ISA and PCI devices are in their logical places. You could > find the outliers immediately because they are so few. :) Cool. Let's fix them though. > I can certainly put them in hw/misc if you prefer, but hw/vfio_pci.c > makes more sense to me as hw/pci/vfio.c than as hw/misc/vfio.c. > > Paolo