From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNOLy-0000JU-I8 for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:07:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNOLs-0007b3-HM for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:07:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNOLs-0007aw-AA for qemu-devel@nongnu.org; Wed, 03 Apr 2013 10:07:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r33E7leN012806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Apr 2013 10:07:47 -0400 Date: Wed, 3 Apr 2013 17:08:42 +0300 From: "Michael S. Tsirkin" Message-ID: <20130403140841.GE22200@redhat.com> References: <1364914749-11141-1-git-send-email-pbonzini@redhat.com> <1364914749-11141-21-git-send-email-pbonzini@redhat.com> <20130403104219.GA18803@redhat.com> <20130403105151.GA18936@redhat.com> <515C17BB.3010706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515C17BB.3010706@redhat.com> Subject: Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On Wed, Apr 03, 2013 at 01:51:23PM +0200, Paolo Bonzini wrote: > Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto: > >>> > > default-configs/i386-softmmu.mak | 4 ++++ > >>> > > default-configs/x86_64-softmmu.mak | 4 ++++ > >>> > > hw/i386/Makefile.objs | 7 ++----- > >>> > > hw/isa/Makefile.objs | 6 ++++++ > >>> > > hw/{ => isa}/debugexit.c | 0 > >>> > > hw/{ => isa}/lpc_ich9.c | 0 > >>> > > hw/{ => isa}/pc-testdev.c | 0 > >> > > >> > This at least seems wrong. debug devices should be in > >> > hw/debug or hw/test. And it does not matter that LPC > >> > uses some ISA ports. It's a chipset device. > >> > So hw/chipset or something ... > >> > > > Maybe hw/system/ or hw/bridge/ > > > > > > lpc_ich9.c is an ISA bridge, hence it is in hw/isa. > > debugexit and pc-testdev are exceptions. I didn't really have a better > place. > > Paolo hw/misc Please don't just move files to random places: if unsure, leave files in place.