From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNfTu-0008WO-V4 for qemu-devel@nongnu.org; Thu, 04 Apr 2013 04:25:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNfTp-0001cs-IW for qemu-devel@nongnu.org; Thu, 04 Apr 2013 04:25:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNfTp-0001cU-9h for qemu-devel@nongnu.org; Thu, 04 Apr 2013 04:25:09 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r348P86e001420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Apr 2013 04:25:08 -0400 Date: Thu, 4 Apr 2013 10:25:06 +0200 From: Kevin Wolf Message-ID: <20130404082506.GB3060@dhcp-200-207.str.redhat.com> References: <1364986038-17514-1-git-send-email-kwolf@redhat.com> <515D34D0.2010106@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515D34D0.2010106@redhat.com> Subject: Re: [Qemu-devel] [PATCH] usb-storage: Forward serial number to scsi-disk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Am 04.04.2013 um 10:07 hat Gerd Hoffmann geschrieben: > On 04/03/13 12:47, Kevin Wolf wrote: > > usb-storage takes care to fetch the USB serial number from -drive > > options, but it neglected to pass its own 'serial' property to the > > scsi-disk it creates. With this patch, the 'serial' qdev property and > > the 'serial' option in -drive behave the same and correctly apply the > > serial number on both USB and SCSI level. > > Looks good. Do you stick it into the block branch or should I pick it > up into the usb queue? I can take it through the block branch. I'll add your Acked-by then. Kevin