From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkox-0001Gc-7E for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNkop-0001xj-DI for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:07:19 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:39992 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNkop-0001xW-5N for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:07:11 -0400 Date: Thu, 4 Apr 2013 16:08:10 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20130404140810.GA7026@irqsave.net> References: <20130402153328.GA4300@irqsave.net> <87ppycdbtu.fsf@linux.vnet.ibm.com> <20130402193316.GA4308@irqsave.net> <87fvz8cedy.fsf@linux.vnet.ibm.com> <20130404123738.GD4250@irqsave.net> <515D832E.6040603@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <515D832E.6040603@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Virtio 9p live migration patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , quintela@redhat.com, "Aneesh Kumar K.V" , qemu-devel@nongnu.org There is still the need to serialize the fid linked list. I saw in the current code base that virtio-blk.c was using the old API to serialize a linked list. Does writing support for serializing linked list in vmstate worth it ? Or is it better to keep the old API to serialize ? Regards Beno=EEt > Le Thursday 04 Apr 2013 =E0 15:42:06 (+0200), Paolo Bonzini a =E9crit : > Il 04/04/2013 14:37, Beno=EEt Canet ha scritto: > > We also need to ensure new 9p request are blocked. >=20 > Migration runs with the VM paused. It would be simplest to flush all > the requests before migrating, that's what the block layer does. (The > migration of requests we have in virtio-blk, scsi-disk etc. is only for > rerror/werror=3Dstop; it is not invoked in the common case). >=20 > Paolo >=20