From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNlPc-0007Qc-8Y for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:45:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNlPZ-00006R-2q for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:45:12 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:33482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNlPY-0008VP-Qp for qemu-devel@nongnu.org; Thu, 04 Apr 2013 10:45:09 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Apr 2013 15:42:22 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8F0FE2190056 for ; Thu, 4 Apr 2013 15:47:05 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r34EisLg53281016 for ; Thu, 4 Apr 2013 14:44:54 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r34Ej3sc013460 for ; Thu, 4 Apr 2013 08:45:04 -0600 Date: Thu, 4 Apr 2013 16:45:02 +0200 From: Cornelia Huck Message-ID: <20130404164502.4cf3d341@gondolin> In-Reply-To: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com> References: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org On Thu, 4 Apr 2013 16:28:58 +0200 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, > they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and > have a virtio-serial. > > You can checkout my branch here: > > git://project.greensocs.com/qemu-virtio.git virtio-serial-v5 > > Note that it is nearly the same series as virtio-blk and virtio-scsi > refactoring. > > I made basic tests (with linux guests) on: > * qemu-system-i386 Still looks sane on s390-virtio and virtio-ccw. Tested-by: Cornelia Huck Reviewed-by: Cornelia Huck > > Changes v4 -> v5: > * Fixed rebase issue with nvector and the clarifying comment. > * Changed property macro for s390 and ccw device too. > > Changes v3 -> v4: > * Removed serial configuration field ommited in VirtioCCWDevice structure. > > Changes v2 -> v3: > * Added CCW device. > * Rebased. > > Thanks, > > Fred > > KONRAD Frederic (7): > virtio-serial: add the virtio-serial device. > virtio-serial-pci: switch to the new API. > virtio-serial-s390: switch to the new API. > virtio-serial-ccw: switch to the new API. > virtio-serial: cleanup: init and exit functions. > virtio-serial: cleanup: use QOM casts. > virtio-serial: cleanup: remove qdev field. > > hw/s390x/s390-virtio-bus.c | 31 +++++---- > hw/s390x/s390-virtio-bus.h | 12 +++- > hw/s390x/virtio-ccw.c | 29 +++++---- > hw/s390x/virtio-ccw.h | 12 +++- > hw/virtio-pci.c | 131 +++++++++++++++++++------------------ > hw/virtio-pci.h | 14 +++- > hw/virtio-serial-bus.c | 157 +++++++++++++++++++++++++++------------------ > hw/virtio-serial.h | 13 +++- > 8 files changed, 239 insertions(+), 160 deletions(-) >