* [Qemu-devel] [PATCH] linux-user: Don't omit comma for strace of rt_sigaction()
@ 2013-03-28 14:33 Peter Maydell
2013-04-05 12:40 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2013-03-28 14:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Riku Voipio, patches
Pass the 'last' parameter of print_signal() through to
print_raw_param(); this fixes a problem where we weren't printing
the comma separator for strace of rt_sigaction() when the signal
was an unnamed (ie realtime) one:
6856 rt_sigaction(230xf6fff870,0xf6fff8fc) = 0
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/strace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 0fbae3c..ea6c1d2 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -143,7 +143,7 @@ print_signal(abi_ulong arg, int last)
case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break;
}
if (signal_name == NULL) {
- print_raw_param("%ld", arg, 1);
+ print_raw_param("%ld", arg, last);
return;
}
gemu_log("%s%s", signal_name, get_comma(last));
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Don't omit comma for strace of rt_sigaction()
2013-03-28 14:33 [Qemu-devel] [PATCH] linux-user: Don't omit comma for strace of rt_sigaction() Peter Maydell
@ 2013-04-05 12:40 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-04-05 12:40 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, Riku Voipio, qemu-devel, patches
On Thu, Mar 28, 2013 at 02:33:24PM +0000, Peter Maydell wrote:
> Pass the 'last' parameter of print_signal() through to
> print_raw_param(); this fixes a problem where we weren't printing
> the comma separator for strace of rt_sigaction() when the signal
> was an unnamed (ie realtime) one:
> 6856 rt_sigaction(230xf6fff870,0xf6fff8fc) = 0
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> linux-user/strace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-05 12:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-28 14:33 [Qemu-devel] [PATCH] linux-user: Don't omit comma for strace of rt_sigaction() Peter Maydell
2013-04-05 12:40 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).