From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPCf1-0006yu-R3
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 10:03:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPCf0-0000g8-GZ
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 10:03:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UPCf0-0000fu-8i
	for qemu-devel@nongnu.org; Mon, 08 Apr 2013 10:03:02 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r38E30LD027284
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 8 Apr 2013 10:03:01 -0400
Date: Mon, 8 Apr 2013 10:02:59 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130408100259.5cf4f7f0@redhat.com>
In-Reply-To: <a7d1f76cb95291dee21569554b4d3ec3718b23de.1365332961.git.minovotn@redhat.com>
References: <a7d1f76cb95291dee21569554b4d3ec3718b23de.1365332961.git.minovotn@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] New cpu-max field in query-machines QMP
	command output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>

On Mon,  8 Apr 2013 12:00:35 +0200
Michal Novotny <minovotn@redhat.com> wrote:

> This alters the query-machines QMP command to output information
> about maximum number of CPUs for each machine type with default
> value 1 in case the number of max_cpus is not set.
> 
> Signed-off-by: Michal Novotny <minovotn@redhat.com>
> ---
>  qapi-schema.json | 2 +-
>  vl.c             | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..39cae4b 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2865,7 +2865,7 @@
>  ##
>  { 'type': 'MachineInfo',
>    'data': { 'name': 'str', '*alias': 'str',
> -            '*is-default': 'bool' } }
> +            '*is-default': 'bool', 'cpu-max': 'int' } }

Please, document the new field.

Also, how is this affected by the CPU hotplug support?

>  
>  ##
>  # @query-machines:
> diff --git a/vl.c b/vl.c
> index a8bba04..c05b3d3 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1617,6 +1617,7 @@ MachineInfoList *qmp_query_machines(Error **errp)
>          }
>  
>          info->name = g_strdup(m->name);
> +        info->cpu_max = !m->max_cpus ? 1 : m->max_cpus;
>  
>          entry = g_malloc0(sizeof(*entry));
>          entry->value = info;