From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] configure: Don't fall back to gthread coroutine backend
Date: Mon, 8 Apr 2013 12:58:49 +0200 [thread overview]
Message-ID: <20130408105849.GD12076@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1363283830-22717-3-git-send-email-peter.maydell@linaro.org>
On Thu, Mar 14, 2013 at 05:57:10PM +0000, Peter Maydell wrote:
> -block-obj-$(CONFIG_WIN32) += coroutine-win32.o
"win32"
> +block-obj-y += coroutine-$(CONFIG_COROUTINE_BACKEND).o
...backend name expanded into object file name...
> +if test "$coroutine" = ""; then
> + if test "$mingw32" = "yes"; then
> + coroutine=windows
"windows"
Please change "windows" to "win32" so the Windows build works.
Stefan
next prev parent reply other threads:[~2013-04-08 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 17:57 [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic Peter Maydell
2013-03-14 17:57 ` [Qemu-devel] [PATCH v2 1/2] configure: Provide and use convenience error reporting function Peter Maydell
2013-03-14 17:57 ` [Qemu-devel] [PATCH v2 2/2] configure: Don't fall back to gthread coroutine backend Peter Maydell
2013-04-08 10:58 ` Stefan Hajnoczi [this message]
2013-03-15 8:09 ` [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic Paolo Bonzini
2013-03-25 13:50 ` Peter Maydell
2013-04-04 10:22 ` Peter Maydell
2013-04-06 1:26 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408105849.GD12076@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).